You are missing the fact that he is not charitable. They had to close his charity for spending the donations on themselves.
The "donation" of his salary is a Fox "news" hoax, doesn't even cover his golf outings, this article is a year old, he passed Obama’s 8 years in 2.5 years.
Trump's Golfing has Cost Taxpayers $102 Million, Just $12.7 Million Behind Obama's Travel During Entire Presidency: Report
https://www.newsweek.com/trump-golf-...report-1432550
Judge signs off on shutdown of Trump Foundation after ‘pattern of illegality’
https://www.theguardian.com/us-news/...utdown-lawsuit
A New York judge has signed off on a deal to shut down Donald Trump’s personal charity after a lawsuit exposed a “shocking pattern of illegality”.